factotum: double-check RSA/DSA keys when loading R=rsc http://codereview.appspot.com/463041
diff --git a/src/cmd/auth/factotum/dsa.c b/src/cmd/auth/factotum/dsa.c index c0d199e..ced1035 100644 --- a/src/cmd/auth/factotum/dsa.c +++ b/src/cmd/auth/factotum/dsa.c
@@ -86,6 +86,10 @@ || (priv->pub.q=strtomp(a, nil, 16, nil))==nil) goto Error; strlwr(a); + if(!probably_prime(priv->pub.p, 20) && !probably_prime(priv->pub.q, 20)) { + werrstr("dsa: p or q not prime"); + goto Error; + } if((a=strfindattr(k->attr, "alpha"))==nil || (priv->pub.alpha=strtomp(a, nil, 16, nil))==nil) goto Error;
diff --git a/src/cmd/auth/factotum/rsa.c b/src/cmd/auth/factotum/rsa.c index a865810..95545f9 100644 --- a/src/cmd/auth/factotum/rsa.c +++ b/src/cmd/auth/factotum/rsa.c
@@ -199,6 +199,10 @@ || (priv->q=strtomp(a, nil, 16, nil))==nil) goto Error; strlwr(a); + if(!probably_prime(priv->p, 20) || !probably_prime(priv->q, 20)) { + werrstr("rsa: p or q not prime"); + goto Error; + } if((a=strfindattr(k->privattr, "!kp"))==nil || (priv->kp=strtomp(a, nil, 16, nil))==nil) goto Error;