commit 725d9fd7952a63c09f50d5544d0b306177462d43
author rsc <devnull@localhost> Thu Jul 28 04:47:00 2005 +0000
committer rsc <devnull@localhost> Thu Jul 28 04:47:00 2005 +0000
tree b5f84ac5821f7ae0d351496561cddac7f15a1e75
parent 34e8254fb8cc206664fc9dcba3c7c8ae1de6ab85

winunlock bug

src/cmd/acme/wind.c

diff --git a/src/cmd/acme/wind.c b/src/cmd/acme/wind.c
index 5d409a9..2f015fe 100644
--- a/src/cmd/acme/wind.c
+++ b/src/cmd/acme/wind.c
@@ -145,7 +145,6 @@
 	int i;
 	File *f;
 
-//fprint(2, "winlock %p %d %lux\n", w, owner, getcallerpc(&w));
 	f = w->body.file;
 	for(i=0; i<f->ntext; i++)
 		winlock1(f->text[i]->w, owner);
@@ -157,16 +156,17 @@
 	int i;
 	File *f;
 
-//fprint(2, "winunlock %p %lux\n", w, getcallerpc(&w));
+	/*
+	 * subtle: loop runs backwards to avoid tripping over
+	 * winclose indirectly editing f->text and freeing f
+	 * on the last iteration of the loop.
+	 */
 	f = w->body.file;
-	for(i=0; i<f->ntext; i++){
+	for(i=f->ntext-1; i>=0; i--){
 		w = f->text[i]->w;
 		w->owner = 0;
 		qunlock(&w->lk);
 		winclose(w);
-		/* winclose() can change up f->text; beware */
-		if(f->ntext>0 && w != f->text[i]->w)
-			--i;	/* winclose() deleted window */
 	}
 }